feat(Freecam): Add Exclude Rotation mode to freecam#269
feat(Freecam): Add Exclude Rotation mode to freecam#269IceTank wants to merge 2 commits intolambda-client:1.21.11from
Conversation
… player rotation on specific axis
IceTank
changed the title
| } | ||
| } | ||
|
|
||
| private enum class FreecamRotationMode(override val displayName: String, override val description: String) : NamedEnum, Describable { |
There was a problem hiding this comment.
can remove the Freecam prefix for these enums. Theyre private so theres no need to preface what theyre for. Also while you're cleaning things up, might as well move these enums below the function at the bottom and remove the extra white space under the followTrackPlayer setting
There was a problem hiding this comment.
Can't. RotationMode is already used when configuring the rotation config. The names would conflict.
There was a problem hiding this comment.
The other enum can. Looking at the rotation configs enum, you can move that into the RotationConfig interface at the bottom and then reference it directly through the interface when setting the rotation config. The other configs do this, the rotation config is just a bit old and doesnt do that currently. That would allow you to remove the Freecam suffix
2 participants
This mode lets you configure what rotations are applied to the player when rotation mode in freecam is enabled.
This is useful for when you are in freecam and want to be able to change the view direction of the player without exiting freecam. Possible use cases are elytra flying while in freecam and changing the player's yaw to the freecam yaw while flying.